Skip to content

Set error_log to an empty value if the test relies on that feature #10772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Set error_log to an empty value if the test relies on that feature #10772

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Mar 4, 2023

Some tests fail if the error_log is overriden by the loaded ini configuration. Explicitly set it to an empty value to prevent the failures.
See #10737 (comment)

@nielsdos
Set error_log to an empty value if the test relies on that feature
f7d771d 
Some tests fail if the error_log is overriden by the loaded ini
configuration. Explicitly set it to an empty value to prevent the
failures.
See php#10737 (comment)
@nielsdos
Copy link
Member Author

If nobody has objections I'd like to merge this sometime in the next week.
OP's problem was because their php.ini file set error_log to a file which causes the test output to not be visible in stdout, causing the test failure.

iluuu1994
iluuu1994 approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I'm not sure if any of those should even use error_log in the first place. Maybe it was necessary for Zend/tests/bug79919.phpt to trigger whatever error was fixed there.

@nielsdos nielsdos closed this in 691ff9f Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @iluuu1994